Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower the binary size gate's threshold #935

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Lower the binary size gate's threshold #935

wants to merge 2 commits into from

Conversation

smalis-msft
Copy link
Contributor

Now that it's doing proper baselining we can lower the threshold. Cut it in half for now, from 100kb to 50kb.

@smalis-msft smalis-msft requested a review from a team as a code owner February 28, 2025 19:05
@jstarks
Copy link
Member

jstarks commented Feb 28, 2025

Let's wait until @justus-camp-microsoft fixes the size check to use a better base commit. Otherwise, this will create noise.

@justus-camp-microsoft
Copy link
Contributor

Just opened #936 to try getting a better merge base. Not sure if I need to clean up/re-check out a branch so waiting on a CI run to see what happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstarks jstarks jstarks left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smalis-msft @jstarks @justus-camp-microsoft